[RFC] grapheme_str_split function #13580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youkidearitai
force-pushed
the
grapheme_str_split
branch
4 times, most recently
from
1d9a40a
to
c9ab75f
Compare
|
I create an wiki for grapheme_str_split function. Please see: |
youkidearitai
changed the title
Ayesh
reviewed
Mar 25, 2024
|
@youkidearitai Since this RFC is in the Voting phase, I think it should be removed from the Draft section or am i wrong? |
|
This an RFC is accepted. Change to normal pull request. |
|
@medabkari Thank you! I'm wrong. fixed. |
|
Thanks, you need to rebase from last changes on master. |
youkidearitai
force-pushed
the
grapheme_str_split
branch
from
e77f939
to
e7f9cae
Compare
|
tip: once CI all green, please squash your commits into 1. If you become committer, you ll have to do it anyway ;) |
I noticed that PHP does not have a grapheme cluster based str_split function. So I created the grapheme_str_split function. This feature will allow you to correctly handle emoji and variable selectors. Co-authored-by: Ayesh Karunaratne <Ayesh@users.noreply.github.com>
youkidearitai
force-pushed
the
grapheme_str_split
branch
from
e7f9cae
to
26a7fb4
Compare
Thanks, squashed my commits. |
|
Thank for your work ! |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that PHP does not have a grapheme cluster based str_split function. So I created the grapheme_str_split function.
(PCRE can handle grapheme cluster, It can be processed with
\X.)This feature will allow you to correctly handle emoji and Variation Selectors.
I would like to discuss it internal and submit an RFC.